Skip to content

Revert "[SYCL] Enable PI unit testing on multiple plugins. (#1647)" #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2020

Conversation

vladimirlaz
Copy link
Contributor

This reverts commit 98119bd due to regressions:

@vladimirlaz vladimirlaz requested review from smaslov-intel and a team as code owners May 15, 2020 11:10
@nyalloc
Copy link
Contributor

nyalloc commented May 15, 2020

Sorry to see the new test is causing regressions on systems with no available OpenCL plugin. I think it would be more valuable to address the issues that the unit test exposed, rather than removing the unit test. Myself and the team at codeplay are happy to help to fix this issue.

@Ruyk
Copy link
Contributor

Ruyk commented May 15, 2020

I am curious, how did this get merged in the first place? is there a different group of test being run on master than per PR?

@bader
Copy link
Contributor

bader commented May 15, 2020

Sorry to see the new test is causing regressions on systems with no available OpenCL plugin. I think it would be more valuable to address the issues that the unit test exposed, rather than removing the unit test.

This is not the reason we revert the patch because developers are expected to have OpenCL installed and this issue impact is minimal - post-commit status only.

The main reason is that pre-commit checks are failing and it impacts the development process.

Myself and the team at codeplay are happy to help to fix this issue.

Thanks! I appreciate your readiness to help and from our side we are committed to provide any information you need to fix this issue.

I am curious, how did this get merged in the first place?

I don't know, but it's either sporadic problem or conflict with other PR.

@bader bader merged commit 5ad2b58 into intel:sycl May 15, 2020
@bader
Copy link
Contributor

bader commented May 15, 2020

@StuartDAdams, could you investigate the problems I reported to in #1647 and re-submit the fixed patch, please?

@vladimirlaz vladimirlaz deleted the revert_unit_tests branch May 26, 2020 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants